cmd/alloc: allocated URL to clipboard does not work on Linux #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the interesting find! But I guess this change will block the alloc command, how about that we change the Write operation to the daemon side because daemon is running in the background and wont exit anyway? |
|
I agree. It's definitely a better idea. In fact, daemon rpc service had written url to clipboard, but it lose effectiveness after write operation in alloc command. |
changkun
approved these changes
Nov 7, 2021
changkun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clipboard.writedoes't work on my linux device when main goroutine exit immediately after it return, which cause allocated url can't be written into clipboard. So to fix it, I make writing clipboard operation block util clipboard is updated to guarantee clipboard can be written into successfully.